Add MS-SQL Server support#4
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
Co-authored-by: alexandru <11753+alexandru@users.noreply.github.com>
Co-authored-by: alexandru <11753+alexandru@users.noreply.github.com>
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the MS-SQL vendor adapter and migrations per
plans/mssql-support-implementation.md, porting the SQL dialect differences from the original Scala implementation.MsSqlServerAdapterNew sealed subclass of
SQLVendorAdapterwith MS-SQL specific query syntax:TOP Ninstead ofLIMIT N— overridesselectByKey,selectAllAvailableWithLock,selectFirstAvailableWithLock,acquireManyOptimisticallyWITH (UPDLOCK)onselectForUpdateOneRow,WITH (UPDLOCK, READPAST)on poll queries to prevent concurrent pollers from blocking on the same rowIF NOT EXISTS ... BEGIN INSERT ... ENDinstead of insert-catch-duplicateMsSqlServerMigrationsTable creation using MS-SQL types:
NVARCHAR,DATETIMEOFFSET,BIGINT IDENTITY(1,1). Composite primary key(pKey, pKind)with a separate unique index onid, matching the old Scala schema.Wiring
SQLVendorAdapter.create()routesJdbcDriver.MsSqlServerto the new adapterDelayedQueueJDBC.runMigrations()routes toMsSqlServerMigrationsselectByKeyandselectAllAvailableWithLockmadeopenon the base class to allow MS-SQL overridesWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
docs.oracle.com/usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:+UseParallelGC -Xmx2g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en(dns block)/usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java -XX:+HeapDumpOnOutOfMemoryError -XX:+AlwaysPreTouch @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath229983155010189027txt -Xmx2g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Worker Daemon 3'(dns block)kotlinlang.org/usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:+UseParallelGC -Xmx2g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en(dns block)/usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java -XX:+HeapDumpOnOutOfMemoryError -XX:+AlwaysPreTouch @/home/REDACTED/.gradle/.tmp/gradle-worker-classpath229983155010189027txt -Xmx2g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant worker.org.gradle.process.internal.worker.GradleWorkerMain 'Gradle Worker Daemon 3'(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.